xplat/js/react-native-github/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm (#57833) - #57833
Closed
meta-codesync[bot] wants to merge 1 commit into
Closed
xplat/js/react-native-github/packages/react-native/Libraries/PushNotificationIOS/RCTPushNotificationManager.mm (#57833)#57833meta-codesync[bot] wants to merge 1 commit into
meta-codesync[bot] wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
cortinico
approved these changes
Aug 5, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync
Bot
changed the title
meta-codesync Bot
pushed a commit
that referenced
this pull request
Aug 8, 2026
…ficationIOS/RCTPushNotificationManager.mm (#57833) Summary: ...Actions taken: 1. Ran build_codegen_spec to generate the FBReactNativeSpec protocol and located/read the `NativePushNotificationManagerIOSSpec` protocol. 2. Ran apply_cast_mod, which mechanically converted all clean methods and flagged two `type-mismatch` methods. 3. Hand-reconciled `cancelLocalNotifications:` and `removeDeliveredNotifications:` by moving to the spec's exact parameter types and restoring the implicit `RCTConvert` coercion in the body. 4. Ran buck_build_verify (BUILD SUCCEEDED) and Lint (no lints). Verified no `RCT_EXPORT_METHOD`/`RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD` macros remain. </summary> </invoke> _____ * Do **NOT** post in the CodemodService Feedback group about this specific diff. * If you have feedback, comment on the diff and use an appropriate diff action. This [diff was created](https://www.internalfb.com/intern/sandcastle/job/18014401344983091/) with [CodemodService](https://www.internalfb.com/codemod_service/CodemodConfigDevmateDropRctExportMethod). Reviewed By: cortinico, christophpurrer Differential Revision: D114840928
meta-codesync
Bot
force-pushed
the
export-D114840928
branch
from
August 8, 2026 22:54
d6a093e to
6a20b19
Compare
…ficationIOS/RCTPushNotificationManager.mm (#57833) Summary: ...Actions taken: 1. Ran build_codegen_spec to generate the FBReactNativeSpec protocol and located/read the `NativePushNotificationManagerIOSSpec` protocol. 2. Ran apply_cast_mod, which mechanically converted all clean methods and flagged two `type-mismatch` methods. 3. Hand-reconciled `cancelLocalNotifications:` and `removeDeliveredNotifications:` by moving to the spec's exact parameter types and restoring the implicit `RCTConvert` coercion in the body. 4. Ran buck_build_verify (BUILD SUCCEEDED) and Lint (no lints). Verified no `RCT_EXPORT_METHOD`/`RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHOD` macros remain. </summary> </invoke> _____ * Do **NOT** post in the CodemodService Feedback group about this specific diff. * If you have feedback, comment on the diff and use an appropriate diff action. This [diff was created](https://www.internalfb.com/intern/sandcastle/job/18014401344983091/) with [CodemodService](https://www.internalfb.com/codemod_service/CodemodConfigDevmateDropRctExportMethod). Reviewed By: cortinico, christophpurrer Differential Revision: D114840928
meta-codesync
Bot
force-pushed
the
export-D114840928
branch
from
August 8, 2026 22:57
6a20b19 to
0b7edd5
Compare
Author
|
This pull request has been merged in db662ca. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
...Actions taken:
NativePushNotificationManagerIOSSpecprotocol.type-mismatchmethods.cancelLocalNotifications:andremoveDeliveredNotifications:by moving to the spec's exact parameter types and restoring the implicitRCTConvertcoercion in the body.RCT_EXPORT_METHOD/RCT_EXPORT_BLOCKING_SYNCHRONOUS_METHODmacros remain.This diff was created with CodemodService.
Reviewed By: cortinico, christophpurrer
Differential Revision: D114840928